[Bug] Broken ETF functionalities #1976
Merged
+20,394
−19,761
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tries to solve #1972 by changing the code in stockanalysis_model.py to ensure it extracts the data from stockanalysis.com correctly
Also modifies the code in etf_controller.py to handle comparison between ETFs when spaces are used instead of commas (the parser isn't able to interpret arguments with spaces correctly)
Before:
After:
How has this been tested?
Checklist:
Others
pre-commit install
.pytest tests/...
.